Closed
Bug 621144
Opened 14 years ago
Closed 14 years ago
ConservativeGCThreadData::recordStackTop should annotate its use of setjmp
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: igor)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.01 KB,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
of 116 calls to setjmp within a coverity analysis, only 5 don't check setjmp for failure.
the glibc(?) manual says:
setjmp() returns 0 if returning directly and non-zero when returning from longjmp().
Igor says that setjmp is used to record registers not for a longjmp.
He offered to add a comment explaining its uses and a (void) or similar to help coverity (and similar) users.
oh, technically coverity sees this as a _setjmp call not a setjmp call (the distinction being that it does not save signal context).
|
Assignee | |
Comment 2•14 years ago
|
||
Comments and (void) annotation
Attachment #499512 -
Flags: review?(timeless)
Attachment #499512 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 4•14 years ago
|
||
Comment on attachment 499512 [details] [diff] [review]
v1
Monimating for 2.0: this is an annotation-only patch to help with coverity analysis.
Attachment #499512 -
Flags: approval2.0?
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Attachment #499512 -
Flags: approval2.0?
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•